Save selected strokes #711
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Assets/Scripts/SketchControlsScript.cs
|
Seems ok to me, but I'd prefer if someone who used this functionality tried it a bit too |
|
Found a couple of blockers on more complex scenes |
# Conflicts: # Assets/Settings/Localization/Strings/Strings Shared Data.asset # Assets/Settings/Localization/Strings/Strings_en.asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A replacement for the current "Save selected strokes to model library".
That uses USD and is hard to support on mobile. Also - the strokes are baked to meshes and are no longer editable.
This branch takes a different approach - saved strokes are .tilt files which can be merged in similar to existing "Merge sketch" functionality. They will be appear as regular strokes once merged and are fully editable.